Skip to content
This repository was archived by the owner on Mar 7, 2018. It is now read-only.

Conversation

@jychen7
Copy link

@jychen7 jychen7 commented Dec 8, 2014

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you just return status 204 the comment will not be necessary anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the existing pattern in the file -- they should all be modified in this way if desired.

My preference is to leave it as a comment, so that you don't have to look up 204. IMHO it is not a very common HTTP response code.

@terraboops
Copy link
Contributor

This PR adds new functionality with associated tests -- no breaking changes. 👍 for merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants